The overwhelming majority of warriors and paladins I know went blacksmithing. This is very understandable because it allows you to create your own armor and weapons and save the money of creating them yourself. I did this too, but about halfway through I started to wonder if it was really worth it.
Smithing is one of the most difficult professions on World of Warcraft. It requires the user to find a great deal of metals, smelt them down, and forge the armor. The biggest problem is the sheer volume of metal you need. You often find yourself using 15-20 bars of your respective metal to get just one point of skill. And very quickly you grow out of the normal patterns and start needing rare and expensive gemstones to complete your work. To make matters worse, most good armor and weapons are only built from rare and expensive patterns.
I personally found it so much easier to find other master blacksmiths and give them materials and tips for the use of their skills. If you give them mats, very few craftsmen will refuse to make something for a tip, no matter how small. It usually comes at no cost to them, so it's free money. You can sell the leftover materials on the auction house and get yourself much more money.
Of course when you hit endgame, you can make some amazing armor sets only usable by master smiths. You can also finally make money, and lots of it, crafting and selling great weapons. I would wait until you're a high level and can easily afford the costs of smithing, and quickly gather the materials. Until then, gathering professions are great for making lots of quick and easy cash.